Glyphon text rendering #369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've extended the supported options to: #[derive(Debug, Clone, Serialize, Deserialize, Type)]
pub struct Text {
pub x: f32,
pub y: f32,
pub text_color: Option<[u8; 3]>,
pub background_color: Option<Color>,
pub background_opacity: Option<f32>,
pub padding: Option<f32>,
pub font_size: Option<f32>,
pub line_height: Option<f32>,
pub content: String,
}Known bugs:
I suspect this will need to be extended with rounded corners in the future but that can be a separate PR. |
|
🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the text rendering part of #361. Related to #364.
This PR allows rendering text onto the video element using glyphon. In the code
ProjectUniforms::newtakes an extra parameter that when set to a string causes it to render on top (it's off by default so you will need to update the code to see it).This can be used for captioning in the future.
This PR also upgrades to the latest wgpu.